Was he trying to use me for a green card or am I being prejudiced?

Not all Moroccans are wanting to scam foreigners for visas. Some are, so being cautious is genuine.  But dont over think things based on an unfounded suspicion. I think you should apologize to him and discuss this further and honestly with him. You may have been over thinking the situation with YOUR FRIEND.  As he had not been asking you for a visa, you should not have been quick to assume that was his interest in you. There is nothing wrong with talking about this concern with him. It is far better than asking uninvolved strangers.

Your suspisions may be founded, but it is just as likely He may have truly enjoyed being with you.  He might have his own awkward relationship ideas too. Friendships between men and women are not encouraged in Morocco. The pressure to marry any person of the opposite sex is so great that many people often choose to avoid mixed gender friendship all together. Many Moroccans end up married to people they really don't know because there they are not allowed to date normally as we in the west do things. Being friends with a girl on the internet is often a very safe way for a man to have a low pressure friendship with a nice girl. 

Romance over the Internet is all about a fantasy that involves interactions between real people, but it should never become overwhelmingly analyzed until the people involved in that fantasy relationship can become real by physical proximity. If sharing a intelectual friendship that may involve a few romantic moments over the internet is enjoyable, then letting this destructive ideas about visa fraud interfere with your friendship is sad.

Even the most beautiful people have self-esteem issues, and a handsome man may be wanting an honnest emotional and mental connection with a real woman that he cannot find with a cute little girl who is lost in her own physical attraction to him. I understand your self-esteem issues leading you to suspicions that are counter productive about someone you find attractive.  I have some similar issues. I don't think that I am a beautiful woman. I think my husband is far better looking than me. He is also a bit younger than me and that compounds my insecurity even more. It also adds to the cruel cliche other people like to direct my way because I let them foster my own doubt in myself. But I can't see through my man's eyes. To assume the worst about a man who is interested in you is an easy way to sell yourself short in life.

He may not be the love of your life, but what is the harm in sharing a few conversations and intimate moments via chat.

I had a long distance relationship with my husband for about a year before I physically met him. After moving to Morocco,  that relationship blossom into a normal romance that continued for over a year before we married in 2011. He was not interested in me for a visa, yet everyone (friends/family both his and mine) assume he was. Most of our marriage i lived in Morocco. I had to convince him to try for a visa only after I needed to return to America over a family crisis.

I will not kid you, my life and marriage is far from perfect. Life has ups and downs. My martiage is no different. We are currently experiencing some very hard times. I don't know what will happen.  But I won't regret taking the chance on him.